Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Changed Zshare-generics to n on Windows #2016

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Changed Zshare-generics to n on Windows #2016

wants to merge 1 commit into from

Conversation

lukors
Copy link
Contributor

@lukors lukors commented Apr 26, 2021

It seems like this option needs to be off on Windows: bevyengine/bevy-website#131

This change also simplifies the instructions required for the Fast Compiles section of the book: bevyengine/bevy-website#137

@lukors
Changed Zshare-generics to n on Windows
60b3fe7 
It seems like this option needs to be off on Windows: bevyengine#131
@lukors lukors mentioned this pull request Apr 26, 2021
Closed
cart
cart reviewed Apr 27, 2021
View reviewed changes
.cargo/config_fast_builds
@@ -14,7 +14,7 @@ rustflags = ["-C", "link-arg=-fuse-ld=/usr/local/bin/zld", "-Zshare-generics=y"]

[target.x86_64-pc-windows-msvc]
linker = "rust-lld.exe"
rustflags = ["-Zshare-generics=y"]
rustflags = ["-Zshare-generics=n"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably just remove the rustflags section entirely here. generic sharing is off by default last time i checked.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

share-generics is off by default, but only with --release, otherwise it's apparently on by default. This is where I got this information rust-lang/rust#67276 and I've verified it on my machine by successfully doing cargo +stable run --features bevy/dynamic --release, which doesn't work without --release.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation O-Windows Specific to the Windows desktop operating system labels Apr 27, 2021
bayswaterpc added a commit to bayswaterpc/bevy_egui that referenced this pull request May 2, 2021
@bayswaterpc
Working commit
9b5d564 
Followed advice from the following to get it working
bevyengine/bevy#2016
This was referenced May 2, 2021
Closed
Closed
@cart cart added the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Jul 23, 2021
@mockersf mockersf removed the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Jul 24, 2021
@SevenO2
Copy link

SevenO2 commented Aug 29, 2021 •
edited
Loading

What's blocking this merge?

I've reproduced the (non)working configurations suggested by @lukors here: bevyengine/bevy-website#137 (comment)

config.toml toolchain target cargo run --features bevy/dynamic
rustflags = ["-Zshare-generics=y"] [nightly] [debug] ⛔ (still the "recommended" setup)
rustflags = ["-Zshare-generics=n"] [nightly] [debug] ✔️
() [nightly] --release ✔️
() +stable --release ✔️
() [nightly] [debug] ⛔
() +stable [debug] ⛔
rustflags = ["-Zshare-generics=y"] [nightly] --release ⛔
rustflags = ["-Zshare-generics=n"] [nightly] --release ✔️

⛔ note: LINK : fatal error LNK1189: library limit of 65535 objects exceeded
      This error occurs with and without linker = "rust-lld.exe" (although I did not try it with all combinations)

I'm running on Windows 10, with MSVC v142 - VS 2019 C++ x86/64 build tools

stable-x86_64-pc-windows-msvc (default)
rustc 1.54.0 (a178d0322 2021-07-26)

nightly-x86_64-pc-windows-msvc (overridden by '.\rust-toolchain.toml')
rustc 1.56.0-nightly (ad02dc46b 2021-08-26)

@mockersf
Copy link
Member

What's blocking this merge?

I guess someone on Windows that can confirm, which you did 👍

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 30, 2021
@cart
Copy link
Member

cart commented Aug 30, 2021

Sorry for letting this sit unmerged / untested :)

@cart
Copy link
Member

cart commented Aug 30, 2021

bors r+

bors bot pushed a commit that referenced this pull request Aug 30, 2021
@lukors
Changed Zshare-generics to n on Windows (#2016)
4465583 
It seems like this option needs to be off on Windows: bevyengine/bevy-website#131

This change also simplifies the instructions required for the Fast Compiles section of the book: bevyengine/bevy-website#137
@bors
Copy link
Contributor

bors bot commented Aug 30, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Changed Zshare-generics to n on Windows [Merged by Bors] - Changed Zshare-generics to n on Windows Aug 30, 2021
@bors bors bot closed this Aug 30, 2021
bilsen pushed a commit to bilsen/bevy that referenced this pull request Sep 2, 2021
@lukors @bilsen
Changed Zshare-generics to n on Windows (bevyengine#2016)
d57daac 
It seems like this option needs to be off on Windows: bevyengine/bevy-website#131

This change also simplifies the instructions required for the Fast Compiles section of the book: bevyengine/bevy-website#137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart left review comments

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
C-Docs An addition or correction to our documentation O-Windows Specific to the Windows desktop operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lukors @SevenO2 @mockersf @cart @alice-i-cecile